You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Intel Hyperscan lib (https://github.com/intel/hyperscan) is a high-performance multiple regex matching library. We are proposing to introduce this lib into Velox. Related discussion: #9823.
Here is a benchmark's result which shows hyperscan performs ~28% better than RE2 in regex matching.
@philo-he This is a major change, but it lacks description. Last time we discussed this in #9823 we found that hyperscan library is no longer maintained. We also found that its main advantage would be when matching a string against multiple regexes at once, but neither Presto nor Spark have functions that allow that. Finally, there are probably semantic differences in hyperscan and re2 and these need be to understood and documented. I haven't looked closely at the benchmark, but benchmarking regex engines in general is very hard as it is difficult to come up with a representative set of use cases. That said, 28% improvement doesn't appear significant enough to justify the complexity of introducing a new dependency and working through all the issues mentioned. Let me know your thoughts.
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.stale
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel Hyperscan lib (https://github.com/intel/hyperscan) is a high-performance multiple regex matching library. We are proposing to introduce this lib into Velox. Related discussion: #9823.
Here is a benchmark's result which shows hyperscan performs ~28% better than RE2 in regex matching.