Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Add .gitkeep to /website/src/lib#1028

Merged
Daniel15 merged 1 commit intofacebookarchive:masterfrom
flarnie:tweakToFixWebsiteBuild
Feb 25, 2017
Merged

Add .gitkeep to /website/src/lib#1028
Daniel15 merged 1 commit intofacebookarchive:masterfrom
flarnie:tweakToFixWebsiteBuild

Conversation

@flarnie
Copy link
Contributor

@flarnie flarnie commented Feb 25, 2017

When we build the website fs.writeFileSync expects the 'lib' directory to exist. We previously had a .gitkeep in this file, even though it's also in the .gitignore. We could probably find a more elegant solution but for now this will fix the build.

@flarnie
Add .gitkeep to /website/src/lib
b5fb6ad 
We need this directory to be present for the initial build of the
website.
@flarnie flarnie self-assigned this Feb 25, 2017
@flarnie flarnie force-pushed the tweakToFixWebsiteBuild branch from d7fdb69 to b5fb6ad Compare February 25, 2017 19:29
@flarnie
Copy link
Contributor Author

flarnie commented Feb 25, 2017

Looks like there is a new error that this does not fix. Looking into that more later today.

@flarnie
Copy link
Contributor Author

flarnie commented Feb 25, 2017

Also tagging @Daniel15 in case you have ideas about the cause of the new error.

@Daniel15
Copy link
Contributor

Daniel15 commented Feb 25, 2017

Oops, I don't know why the .gitkeep file went missing. Sorry about that! Since I broke it, I can take a look and see what's happening :)

TravisCI was running far far behind (several hours) yesterday, so I had to build the site manually on my computer. Unfortunately that meant that I didn't have a chance to see whether the TravisCI build actually worked before going to sleep.

@Daniel15 Daniel15 merged commit 7e33073 into facebookarchive:master Feb 25, 2017
@flarnie
Copy link
Contributor Author

flarnie commented Feb 26, 2017 •
edited
Loading

Thanks for merging this @Daniel15 - I wish I had figured out what is causing that other error. I would expect to see Error: EISDIR: illegal operation on a directory, read if we were calling fs.readFileSync on a directory path instead of a file path, but that doesn't seem possible in any of the places we call fs.readFileSync.

I have some other stuff to catch up on but will look again at this too when I have time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@flarnie flarnie

Labels

CLA Signed documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flarnie @Daniel15 @facebook-github-bot