Conversation
Summary: flexlayout has the same fixtures forked from Yoga, with some disabled, and some added. This syncs that list to Yoga, adding the fixes made to it along with new fixtures. One new test absolute_child_with_max_height_larger_shrinkable_grandchild is failing, along with two fixtures where Chrome had recently changed its behaviors. These are commented out at the moment before I do something smarter with the test runner to allow more fixtures. Differential Revision: D42242096 fbshipit-source-id: dad07c72101c32b48f7c5a5fa8f46d43d2637222
|
This pull request was exported from Phabricator. Differential Revision: D42242096 |
|
@NickGerleman Not the biggest issue, but the test |
|
Looks like gtest allows you to disable tests by prefixing the test name with |
Teaching the test generator to emit annotations to skip tests would be a good concrete step towards getting some of this cleaned up. Patterned after what was done for experimental features, we could maybe add an HTML attribute like Then we would emit for GTest, add |
Summary:
flexlayout has the same fixtures forked from Yoga, with some disabled, and some added. This syncs that list to Yoga, adding the fixes made to it along with new fixtures.
One new test absolute_child_with_max_height_larger_shrinkable_grandchild is failing, along with two fixtures where Chrome had recently changed its behaviors. These are commented out at the moment before I do something smarter with the test runner to allow more fixtures.
Differential Revision: D42242096