Fix gentest compatibility with chrome > 75#1011
Closed
woehrl01 wants to merge 3 commits intofacebook:mainfrom
Closed
Fix gentest compatibility with chrome > 75#1011woehrl01 wants to merge 3 commits intofacebook:mainfrom
woehrl01 wants to merge 3 commits intofacebook:mainfrom
Conversation
Contributor
|
This was updated/fixed with fd180de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the gentest suite to be compatible with chrome >75 by passing
w3c: falseaschromeOptionso that the access to the log is still possible. With the chrome >75 it is also required to pass the logging preferences asgoog:loggingPrefsAdditionally, changes are fixing the copyright header to match the latest version and the usage of the Selenium API directly instead of going the extra route of using
watirThe last change is to exclude the gentests from being formatted by
clang-formatto reduce unnecessary changes.