[RFC] Remove tools/rdb from main repo#9399
Closed
riversand963 wants to merge 1 commit intofacebook:mainfrom
Closed
[RFC] Remove tools/rdb from main repo#9399riversand963 wants to merge 1 commit intofacebook:mainfrom
riversand963 wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
approved these changes
Jan 19, 2022
Contributor
ajkr
left a comment
There was a problem hiding this comment.
LGTM, never heard of anyone using it or what it is for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is one proposal to resolve #9382.
Looking at the code, I can't think of a reason why rdb is an internal component of RocksDB: it does not require
any header files NOT in
include/rocksdb. It's a better idea to host it somewhere else. (I have moved it to https://github.com/riversand963/rocksdb-tools-rdb and archived it). The namingrdbalso conflicts with MyRocks(https://github.com/facebook/mysql-5.6/tree/fb-mysql-5.6.35/storage/rocksdb#readme).
Plus, rdb requires python2 which is not supported any more. No fixes or improvements will be made, even for potential
security bugs (https://www.python.org/doc/sunset-python-2/).
Test plan
make check