[RFC] Add initial CMake support to plugin#9214
Closed
riversand963 wants to merge 4 commits intofacebook:mainfrom
Closed
[RFC] Add initial CMake support to plugin#9214riversand963 wants to merge 4 commits intofacebook:mainfrom
riversand963 wants to merge 4 commits intofacebook:mainfrom
Conversation
0fff279 to
b6af00f
Compare
Contributor
|
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Not a CMake expert, and the current CMake build support added by this PR is unlikely the best way of doing it. Sending out the PR to demonstrate it can work. Test Plan: Will need to update https://github.com/ajkr/dedupfs with CMake build. Also, PR facebook#9170 and PR facebook#9206 both include CMake support for their plugins, and can be used as a proof of concept.
Verified on MSVC 2017 that we can build dedupfs as plugin.
023aea2 to
5e60f13
Compare
Contributor
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Not a CMake expert, and the current CMake build support added by this PR is
unlikely the best way of doing it. Sending out the PR to demonstrate it
can work.
Test Plan:
Will need to update https://github.com/ajkr/dedupfs with CMake build.
Also, PR #9170 and PR #9206 both include CMake support for their
plugins, and can be used as a proof of concept.