Skip to content

Re-enable 390x+cmake* Travis jobs#9110

Closed
adamretter wants to merge 1 commit intofacebook:mainfrom
adamretter:s390x-cmake-travis-ci
Closed

Re-enable 390x+cmake* Travis jobs#9110
adamretter wants to merge 1 commit intofacebook:mainfrom
adamretter:s390x-cmake-travis-ci

Conversation

@adamretter
Copy link
Copy Markdown
Collaborator

@adamretter adamretter commented Nov 1, 2021

Revert "Temporarily disable s390x+cmake* Travis jobs (#9095)"
This reverts commit f2d11b3.

I have now uploaded the CMake deb for s390x provided by @jonathan-albrecht-ibm to our S3 bucket.

@riversand963
Copy link
Copy Markdown
Contributor

I think it's still broken: https://app.travis-ci.com/github/facebook/rocksdb/jobs/546119026

@jonathan-albrecht-ibm
Copy link
Copy Markdown
Contributor

I think it's still broken: https://app.travis-ci.com/github/facebook/rocksdb/jobs/546119026

I think I need to build cmake with openssl support so downloading https:// will work. Let me see if I can rebuild it.

@adamretter
Copy link
Copy Markdown
Collaborator Author

@jonathan-albrecht-ibm Yes you are correct, the CMake binaries do need to be built with SSL support I am afraid.

@jonathan-albrecht-ibm
Copy link
Copy Markdown
Contributor

@adamretter, I've updated the deb and ran a local build. I think this deb should work now. Sorry for the inconvenience.

@adamretter
Copy link
Copy Markdown
Collaborator Author

@jonathan-albrecht-ibm Thanks, I have uploaded your new version with SSL support, and I have just restarted the Travis CI Job.

@adamretter
Copy link
Copy Markdown
Collaborator Author

@jonathan-albrecht-ibm LGTM now. Thanks :-)
@riversand963 okay to merge?

Copy link
Copy Markdown
Contributor

@riversand963 riversand963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@riversand963 merged this pull request in 312d9c4.

@jonathan-albrecht-ibm
Copy link
Copy Markdown
Contributor

Thanks @adamretter and @riversand963 for getting everything working.

@adamretter, I was wondering if it would be possible to add s390x support to the published rockdbjni jar? I could help to get a s390x VM for building it if you need one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants