Turn HarnessTest in table_test into a parameterized test#6974
Closed
ltamasi wants to merge 2 commits intofacebook:masterfrom
Closed
Turn HarnessTest in table_test into a parameterized test#6974ltamasi wants to merge 2 commits intofacebook:masterfrom
ltamasi wants to merge 2 commits intofacebook:masterfrom
Conversation
Summary: `HarnessTest` in `table_test.cc` currently tests many parameter combinations sequentially using nested loops. This is problematic from a testing perspective, since if the test fails, we have no way of knowing how many/which combinations have failed. It can also cause timeouts on our test system due to the sheer number of combinations tested. (Specifically, the parallel compression threads parameter added by facebook#6262 seems to have been the last straw.) The patch turns `HarnessTest` into a parameterized test, so the various parameter combinations can be tested separately and potentially concurrently. It also cleans up the tests a little, fixes `RandomizedLongDB`, which did not get updated when the parallel compression threads parameter was added, and turns `FooterTests` into a standalone test case (since it does not actually need a fixture class). Test Plan: `make check`
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
approved these changes
Jun 12, 2020
Contributor
|
Thank you for improving it! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
HarnessTestintable_test.cccurrently tests many parametercombinations sequentially in a loop. This is problematic from
a testing perspective, since if the test fails, we have no way of
knowing how many/which combinations have failed. It can also cause timeouts on
our test system due to the sheer number of combinations tested.
(Specifically, the parallel compression threads parameter added by
#6262 seems to have been the last straw.)
There is some DIY code there that splits the load among eight test cases
but that does not appear to be sufficient anymore.
Instead, the patch turns
HarnessTestinto a parameterized test, so all theparameter combinations can be tested separately and potentially
concurrently. It also cleans up the tests a little, fixes
RandomizedLongDB, which did not get updated when the parallelcompression threads parameter was added, and turns
FooterTestsinto astandalone test case (since it does not actually need a fixture class).
Test Plan:
make check