Update folly/lang/Align.h (backport to C++11)#6534
Closed
pdillinger wants to merge 2 commits intofacebook:masterfrom
Closed
Update folly/lang/Align.h (backport to C++11)#6534pdillinger wants to merge 2 commits intofacebook:masterfrom
pdillinger wants to merge 2 commits intofacebook:masterfrom
Conversation
Summary: For s390x support, some updates in newer version of Align.h are needed. Upgrading just that file as best we can, with one addition to Portability.h and tweaking new code in Align.h to use C++11 only (no non-trivial constexpr functions). Test Plan: CI, further work in PR facebook#6168
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
adamretter
reviewed
Mar 13, 2020
Collaborator
adamretter
left a comment
There was a problem hiding this comment.
I can't really comment on if it is correct, I don't have the depth of C++ knowledge required.
Contributor
|
@pdillinger has updated the pull request. Re-import the pull request |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
approved these changes
Mar 16, 2020
Contributor
|
@pdillinger merged this pull request in 6c595f0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: For s390x support, some updates in newer version of Align.h are
needed. Upgrading just that file as best we can, with one addition to
Portability.h and tweaking new code in Align.h to use C++11 only (no
non-trivial constexpr functions).
Test Plan: CI, further work in PR #6168