fix ForwardIterator reference to temporary object#3300
Closed
ajkr wants to merge 1 commit intofacebook:masterfrom
Closed
fix ForwardIterator reference to temporary object#3300ajkr wants to merge 1 commit intofacebook:masterfrom
ajkr wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
miasantreble
approved these changes
Dec 20, 2017
Contributor
miasantreble
left a comment
There was a problem hiding this comment.
LGTM, please verify ASAN test passes locally before merging. Thanks
Contributor
|
block test is failing on phabricator, how about re-run? |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Yes, I verified ASAN passes after the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following ASAN error: