@lightmark updated the pull request - view changes

@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lightmark updated the pull request - view changes - changes since last import

@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This PR does not fully fix the issue. Public headers should not reference RocksDB-specific macros (like ROCKSDB_SUPPORT_THREAD_LOCAL in this case). When external projects are compiled against public headers, they do not have this macro defined.

This leads to a compile error such as this:

[2017/05/22 11:48:17.477] /opt/mongodbtoolchain/v2/lib/gcc/x86_64-mongodb-linux/5.4.0/../../../../x86_64-mongodb-linux/bin/ld.gold: error: /data/mci/dd5d58edfe22a7fe3dd43b2b9a7c4dda/rocksdb/librocksdb.a(instrumented_mutex.o): symbol 'rocksdb::perf_context' used as both __thread and non-__thread

@igorcanadi Yes, we realized that the introduction of this flag to public header files may be wrong. I have reverted it from 5.5 release. We need to figure out how to deal with it in master.

@igorcanadi #2380 may solve the problem.