Skip to content

Move two history entries mistake out of 7.9 section#11013

Closed
hx235 wants to merge 1 commit intofacebook:mainfrom
hx235:fix_history_7.9
Closed

Move two history entries mistake out of 7.9 section#11013
hx235 wants to merge 1 commit intofacebook:mainfrom
hx235:fix_history_7.9

Conversation

@hx235
Copy link
Copy Markdown
Contributor

@hx235 hx235 commented Dec 1, 2022

#10892 and #10955 mistakenly added two entries under sealed 7.9.history section. This PR fixes these two.

No need to update 7.9 branch (https://github.com/facebook/rocksdb/blob/7.9.fb/HISTORY.md) cuz it's cut before these two PRs landed

@hx235 hx235 changed the title Move two history entries out of 7.9 Move two history entries mistake out of 7.9 Dec 1, 2022
@hx235 hx235 requested a review from cbi42 December 1, 2022 21:57
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 changed the title Move two history entries mistake out of 7.9 Move two history entries mistake out of 7.9 section Dec 1, 2022
Copy link
Copy Markdown
Contributor

@cbi42 cbi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants