Improve compaction picker for multi-level FIFO#10726
Closed
yhchiang-sol wants to merge 2 commits intofacebook:mainfrom
Closed
Improve compaction picker for multi-level FIFO#10726yhchiang-sol wants to merge 2 commits intofacebook:mainfrom
yhchiang-sol wants to merge 2 commits intofacebook:mainfrom
Conversation
af6bcd0 to
7348dc5
Compare
7348dc5 to
9d1c4b4
Compare
Contributor
Author
|
Abandon this PR as we agree to delete non-L0 files from the left (i.e., one with the smallest key first). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10348 enables FIFO compaction to
open a multi-level DB by generalizing the target level of compaction from L0
to the bottom-most non-empty level while keeping the main compaction picker
logic unchanged.
However, different from L0, files in other levels are not sorted in time order.
As a result, simply evicting the right-most sst file in a non-L0 level might not
necessarily evict the oldest sst file.
This PR fixes this part by using the file creation time for non-L0 files while the
CompactionPicker logic for L0 in FIFOCompaction still unchanged.
Test Plan:
Added additional test cases to ensure the correct FIFO order for multi-level DB.
This PR is based on top of #10348.