-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fsync directory after file ingestion #5287
Copy link
Copy link
Closed
Description
Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://www.facebook.com/groups/rocksdb.dev
Expected behavior
@petermattis pointed me to this. We should sync the DB directory after ingesting an SST file to ensure that SST file can survive a system crash.
Actual behavior
The directory sync is not happening (see repro below).
Steps to reproduce the behavior
I verified with strace that there is indeed no sync on the directory after creating a file during ingestion: https://gist.github.com/ajkr/053b51bb97d5a8957136b2a8cf885c71
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.