Skip to content
This repository was archived by the owner on Feb 1, 2025. It is now read-only.

compile with loose mode#265

Merged
benjamn merged 2 commits intofacebook:masterfrom
hzoo:patch-1
Dec 8, 2016
Merged

compile with loose mode#265
benjamn merged 2 commits intofacebook:masterfrom
hzoo:patch-1

Conversation

@hzoo
Copy link
Copy Markdown
Contributor

@hzoo hzoo commented Dec 8, 2016

If we move the implementation maybe we want to be as close as possible to what it was before?

https://github.com/babel/babel/blob/26b4e0909ef8ec3a45b08f2a475124ed83defdac/package.json#L51-L66

{
"comments": false,
    "presets": [
      [
        "es2015",
        {
          "loose": true
        }
      ],
      "stage-0"
    ],
    "plugins": [
      "./scripts/add-module-exports",
      "transform-runtime",
      "transform-class-properties",
      "transform-flow-strip-types"
    ],
}

the other plugins/presets won't matter if the syntax isn't used so we can ignore that.

@benjamn benjamn merged commit acf11c4 into facebook:master Dec 8, 2016
@hzoo
Copy link
Copy Markdown
Contributor Author

hzoo commented Dec 8, 2016 •
edited
Loading

thoughts on whether we also need to use add-module-exports or we do a require('x').default or we use imports syntax for babel/babel#4881 (comment)?

Or maybe it's just me, it seems to work?

@hzoo hzoo mentioned this pull request Jan 24, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hzoo @benjamn @facebook-github-bot