This repository was archived by the owner on Feb 1, 2025. It is now read-only.
Convert to a Babel plugin#222
Closed
sebmck wants to merge 1 commit intofacebook:masterfrom
babel:babelify
Closed
Conversation
Contributor
|
Great, glad to have a chance to look this over sooner rather than later. Two first thoughts:
|
Contributor
There was a problem hiding this comment.
Removing the require("regenerator").transform API is a pretty big breaking change for any non-Babel consumers of this library.
Contributor
Author
I'll get out a release candidate ASAP so Travis at least shows the errors and you can run this locally without mucking about.
Yeah. Shouldn't be a problem. I'll add a TODO list. |
Contributor
Author
|
cc @benjamn. What's required to move this forward? Would like to get this merged ASAP. |
This was referenced Nov 21, 2016
Contributor
|
Implemented by #259. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP. There are currently ~8 failing tests so I thought I'd put it up for review before I look into them too much. This will heavily improve Babel performance and stability. I know there are ways for regenerator to perform it's compilation in a single pass in the future too (right now there are a few visitors that are ran independently).
NOTE: This wont currently run unless you've got a
developmentbranch locally checked out and everything linked which is a bit of a PITA.AFAIK this was 👍 between @benjamn and @amasad.
TODO:
includeRuntimeoption.regenerator.transformAPI.