add definition and example of how flexbox works#947
Merged
cpojer merged 17 commits intofacebook:masterfrom Jun 12, 2019
ecreeth:patch-1
Merged
add definition and example of how flexbox works#947cpojer merged 17 commits intofacebook:masterfrom ecreeth:patch-1
cpojer merged 17 commits intofacebook:masterfrom
ecreeth:patch-1
Conversation
|
Deploy preview for react-native ready! Built with commit 1eb1994 https://deploy-preview-947--react-native.netlify.com Changes to Thank you for your contributions. |
82 tasks
rickhanlonii
requested changes
May 31, 2019
Member
rickhanlonii
left a comment
There was a problem hiding this comment.
Wow this is great, thank you so much for putting this together!
I left some comments to review! The important changes are to the update the default flexDirection, removing duplicate content, and addressing the image sources in a better way 👍
cpojer
approved these changes
Jun 12, 2019
Contributor
cpojer
left a comment
There was a problem hiding this comment.
This is absolutely fantastic. Thank you so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.