Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I think this should be stable now that we are specifying the Appetize Frame. I think we could further optimize a bit, like asking Appetize not to show the frame, so we can take back a little bit of space, but viewing this on the website, it doesn't look too tall to my eyes (though that is of course subjective). I do notice in the iOS example we end up having a larger gap below the device than above. Is this needed to fit the current Android emulator? Since this is kinda stylistic though, I want to give other reviewers an opportunity to share their thoughts before hitting the merge button. |
|
Setting a static height is still a sort of workaround, since the viewport height of Android and iOS screens differs. Like Nick, I also would like to see the player version with device frames disabled. Maybe then we can guarantee same dimensions? From the quick test on the deploy previe we can reduce the base height to A quick comparison shot: Snack player with new height looks nice in complex examples, but in short ones, it would be nice if we can spare a bit of height viewport, not sure ATM exactly how. Maybe max height could be an additional param, but still, with device frames on we might not able to do much. |
|
After dropping the device frame, the simulator content cropping should no longer occurs, thus wrapper height change is no longer needed. Closing this PR for now, it there are still some issues with Snacks rendering let's create a new issues/PR for them. Thanks @spencerlwahlstrom so much for bringing this problem to our attention! 🙏 |
Fixed out-of-bounds issue #3751, for embedded snack player cutting off android, and ios devices. Changed snack players height so view is no longer cutoff and there is sufficient space surrounding it.