Update link to WebView library#2696
Conversation
|
Hi @mitchiemt11! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: 6bffc1b 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/60f9f56978723c00089ce0ee 😎 Browse the preview: https://deploy-preview-2696--react-native.netlify.app |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Simek
left a comment
There was a problem hiding this comment.
Hi @mitchiemt11, thank you for catching this issue! 👍
It would be nice if you can also include those changes in your PR:
- update the other 404 links on this page and on the WebView guides for iOS and Android, below I have listed the problematic link names:
RCTWebView.m(iOS)ReactWebViewManager.java(Android)WebView.android.js(Android)
- port changes (copy them) to at least the latest versioned docs (for
0.64):
If I'm asking for too much just let me know, I can also correct those links later, after your PR merge. 😉
|
Thanks, I have updated the links. Is it okay? |
Simek
left a comment
There was a problem hiding this comment.
This is great! Thank you so much for the review updates! 👍
No description provided.