fixed introduction md Tabs functionality#2548
Conversation
|
Hi @EkkoKo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for react-native ready! Built with commit 85b9fd2 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Simek
left a comment
There was a problem hiding this comment.
Hi @EkkoKo, thank you so much for catching this issue! 👍
It looks like regression after latest Docusuaurs update (#2547), you can see that on deploy previews before the bump, tabs were working correctly:
Please, if you can, report the issue in the Docusuaurs repository.
The proposed fix looks fine to me and after applying it the tabs are working correctly, thank you for putting time into debugging and solving this! 🙂
In the getting-started page (introduction.md) the Tabs bar is not working properly -
when I click on web it opens ios,
when I click on ios it opens android
and when I click on android it opens web.
The problem seemed to be that the tabs weren't organized in the same order as the getDevNotesTabs array (which was the values for the Tabs element).