Conversation
|
Deploy preview for react-native ready! Built with commit bb29bda https://deploy-preview-1771--react-native.netlify.com Changes to Thank you for your contributions. |
|
|
||
| ```jsx | ||
| static in(easing); | ||
| static in easing; |
There was a problem hiding this comment.
This is a Prettier issue, can we ignore this line?
There was a problem hiding this comment.
This seems like a pretty big deal. How many other places is it doing something/going to do something similar?
There was a problem hiding this comment.
I was bit surprised but it seems that only this line is affected.
I assume that the reason is that in in JS is a keyword and you usually cannot use it as a name for stand-alone variables or functions. Here it's fine because it's static method.
|
I loved it. |
|
@cHaLkdusT Prettier rules are extension (not context) based. This means that until JS code is inside
|
|
What is the reason for the website code snippets having a different prettier config than the core codebase? I could understand some things like additional spacing making things easier to read, but I’m not sure about the trailing comma change |
nearestnabors
left a comment
There was a problem hiding this comment.
@TheSavior Trailing commas are unusual in documentation sample code and tutorials—most of our un-Prettier-ed demos don't have them!
I'm not sure why the site and demo JS are handled differently, but I figure it's better not to go changing things in the site code even though the demo code might need to change with convention. So perhaps that's what was intended!
|
I'm going to close this and retry after the dust of 0.62 settles. |
In #1752 we discussed what an ideal Prettier config would look like: more space, no trailing commas. Applied everywhere