Skip to content

Dimensions 📐 - updated Docs 📑 & new snack examples ✨#1671

Merged
nearestnabors merged 3 commits intofacebook:masterfrom
DaniAkash:dimensions-snack-2
Feb 27, 2020
Merged

Dimensions 📐 - updated Docs 📑 & new snack examples ✨#1671
nearestnabors merged 3 commits intofacebook:masterfrom
DaniAkash:dimensions-snack-2

Conversation

@DaniAkash
Copy link
Copy Markdown
Contributor

Belongs to #1579

Inspiration - To address this stackoverflow question

Contains the snack with both class & functional component examples and also a bit of update to the documentation regarding screen, window & event listener.

Pending items in this PR:

  • useDimensions hook - Done!
  • Info regarding scaling - Somehow this section itself is removed from docs...
  • Verify if rounding is necessary for using Dimensions - It's probably not necessary cuz we will eventually have to work with changing screen sizes and this helps to animate the dimensions.

Previously this was raised in #1601 but closing it cuz the older one has conflicts with master & It's easier to merge this one

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Feb 27, 2020

Deploy preview for react-native ready!

Built with commit 2e02a10

https://deploy-preview-1671--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting so much time into expanding our content here! This section has really been a stumbler for a lot of folks with responsive design backgrounds from Web. I think there's STILL room to go deeper if you're ever keep to tackle it in a separate guide!
mlp_thanks-so-much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants