Skip to content

[docs] Fix code block type and link#1669

Merged
nearestnabors merged 1 commit intofacebook:masterfrom
wodin:patch-5
Feb 27, 2020
Merged

[docs] Fix code block type and link#1669
nearestnabors merged 1 commit intofacebook:masterfrom
wodin:patch-5

Conversation

@wodin
Copy link
Copy Markdown
Contributor

@wodin wodin commented Feb 26, 2020

Fix bad s/js/javascript/ followed by s/javascript/jsx/ for a json code block.
Link to the .md instead of .html version of the file.

@wodin
[docs] Fix code block type and link
ecd80de 
Fix bad `s/js/javascript/` followed by `s/javascript/jsx/` for a `json` code block.
Link to the `.md` instead of `.html` version of the file.
@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Feb 26, 2020

Deploy preview for react-native ready!

Built with commit ecd80de

https://deploy-preview-1669--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

nearestnabors
nearestnabors suggested changes Feb 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have it link to flatlist#getitemlayout? I think including .md isn't working so great in versioned docs...

@wodin
Copy link
Copy Markdown
Contributor Author

wodin commented Feb 26, 2020

Sure. I based that change on the following existing links in the file. I'll change those too then:

This guide is intended to teach you some basics to help you to [troubleshoot performance issues](performance.md#profiling), as well as discuss [common sources of problems and their suggested solutions](performance.md#common-sources-of-performance-problems).

@wodin
Copy link
Copy Markdown
Contributor Author

wodin commented Feb 26, 2020 •
edited
Loading

Actually there are hundreds tens of thousands of instances of something.md#something in the docs, so I'm not sure removing .md is correct?

@wodin
Copy link
Copy Markdown
Contributor Author

wodin commented Feb 27, 2020

Hi @rachelnabors
I'm in no rush for this PR to be merged, but I'm just not sure if I need to do anything more and if so, what.
P.S. I liked the "K-nearest neighbours" pun you used in the past on Twitter.

nearestnabors
nearestnabors approved these changes Feb 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up!
mlp_wow

@nearestnabors nearestnabors merged commit 5bf6082 into facebook:master Feb 27, 2020
@wodin wodin deleted the patch-5 branch February 27, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nearestnabors nearestnabors nearestnabors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wodin @react-native-bot @nearestnabors