Skip to content

Update Exampe stylesheet#1626

Merged
nearestnabors merged 2 commits intofacebook:masterfrom
lcelso:docs/stylesheet
Feb 24, 2020
Merged

Update Exampe stylesheet#1626
nearestnabors merged 2 commits intofacebook:masterfrom
lcelso:docs/stylesheet

Conversation

@lcelso
Copy link
Copy Markdown
Contributor

@lcelso lcelso commented Feb 11, 2020

I have a suggestion to make, both absoluteFill and absoluteFillObject do the same thing. Do you still think it necessary to keep this in the documentation?

Can't we force any of them to become obsolete?
Does it make sense to have two methods that do the same thing?

#1579

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Feb 11, 2020

Deploy preview for react-native ready!

Built with commit 30cf09e

https://deploy-preview-1626--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@tesseralis tesseralis removed their request for review February 11, 2020 21:12
---
id: stylesheet
title: StyleSheet
original_id: stylesheet
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page cannot be referenced. I think this should be id: stylesheet and move it up

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lcelso lcelso changed the title Update page stylesheet Update Exampe stylesheet Feb 12, 2020
Copy link
Copy Markdown
Contributor

@mohamedsgap mohamedsgap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! These are great! Thank you for all these Snack examples!!
mlp_wow

@nearestnabors nearestnabors merged commit 2bc2499 into facebook:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants