Skip to content

docs: Modal updated API and examples#1605

Merged
nearestnabors merged 6 commits intofacebook:masterfrom
Darking360:060220-modal-documentation
Feb 24, 2020
Merged

docs: Modal updated API and examples#1605
nearestnabors merged 6 commits intofacebook:masterfrom
Darking360:060220-modal-documentation

Conversation

@Darking360
Copy link
Copy Markdown
Contributor

@Darking360 Darking360 commented Feb 6, 2020 •
edited
Loading

Modal new examples and API updated check

Issue

#1579

Checks

  • Check updated API for Modal (compared against properties in React Native core)
  • Add examples for functional and Hooks based components.
  • Embed any existing example code in a Snack player

Messages

  • Adding new code blocks as shown by @rachelnabors
  • Adding better styling for example
  • Both function and class example added

@Darking360
New structure for class and functional components examples
8796960 
- Adding new code blocks as shown by @rachelnabors
- Adding better styling for example
- Only initial functional example added
@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Feb 6, 2020 •
edited
Loading

Deploy preview for react-native ready!

Built with commit 5ace07a

https://deploy-preview-1605--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@Darking360 Darking360 changed the title [WIP] docs: Modal updated API and examples docs: Modal updated API and examples Feb 13, 2020
Update modal.md
5ace07a 
Seems like modal should work on Web
@nearestnabors nearestnabors mentioned this pull request Feb 17, 2020
Closed
nearestnabors
nearestnabors suggested changes Feb 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! I want to approve it ASAP! But, I'm wondering why modal isn't working in the Web view of the Snack? Could you investigate?

@Darking360
Copy link
Copy Markdown
Contributor Author

Darking360 commented Feb 19, 2020

@rachelnabors I opened an issue inside Snack Web to check why it's not working for web, and someone commented an error from the minified version, maybe a terser bug, the issue is here: expo/snack-web#34

I was checking on the code implementation for RCTModalHostView from React Native core but I got lost 😅 I'd say to wait until someone from Expo answers the issue maybe? 🤔

@nearestnabors
Copy link
Copy Markdown
Contributor

nearestnabors commented Feb 24, 2020

Gonna merge and CC @brentvatne for future reference!

@nearestnabors
Copy link
Copy Markdown
Contributor

nearestnabors commented Feb 24, 2020

Thank you for your contribution :)
mlp_ur-the-best

@nearestnabors nearestnabors merged commit aa1d005 into facebook:master Feb 24, 2020
@tcdavis
Copy link
Copy Markdown

tcdavis commented Feb 24, 2020

I believe that Modal is not supported in RNWeb currently. necolas/react-native-web#1020
You may want to restrict the supported platforms to just Android and iOS :/

@brentvatne
Copy link
Copy Markdown
Contributor

brentvatne commented Feb 25, 2020

@rachelnabors - the above is true, see https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/Modal/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nearestnabors nearestnabors nearestnabors requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Darking360 @react-native-bot @nearestnabors @tcdavis @brentvatne