Skip to content

docs: add information about useWindowDimensions Hook#1585

Closed
Naturalclar wants to merge 1 commit intofacebook:masterfrom
Naturalclar:docs/addWindowDimensionsHook
Closed

docs: add information about useWindowDimensions Hook#1585
Naturalclar wants to merge 1 commit intofacebook:masterfrom
Naturalclar:docs/addWindowDimensionsHook

Conversation

@Naturalclar
Copy link
Copy Markdown
Contributor

This PR addresses #1315

Added information about useWindowDimensions hook in the Dimensions page.

@react-native-bot
Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit 0a53e60

https://deploy-preview-1585--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should go under the hooks/class toggle we just for function and class components in the Component docs and elsewhere like in the intro to React's state section: https://facebook.github.io/react-native/docs/next/intro-react#state

Thoughts?

@nearestnabors
Copy link
Copy Markdown
Contributor

Ok, had a look and a think, and useWindowDimensions is its own thing, separate from the dimensions API. It should have its own page. Could I ask you to retool this commit into a new page, pretty please?

@Naturalclar
Copy link
Copy Markdown
Contributor Author

@rachelnabors Sure :) Done made a pr in #1676
Closing this PR is favor of #1676

@Naturalclar Naturalclar deleted the docs/addWindowDimensionsHook branch February 27, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants