Add new line between errors #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stack trace lines were
display: inheritwhich was causing them to beinlinewhich was allowing errors to be concatenated.So for the code:
We've got the first console print like so:

However it was only happening for when the ignored frames were displayed. Otherwise it was acting as expected:

It was also acting as expected if there was any cause for the error:

Test plan
After the fix, stack frames never have an error printed in the same line (inline):
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.