[iOS] Use configuration type when adding ndebug flag to pods in release#48193
Closed
benhandanyan wants to merge 2 commits intofacebook:mainfrom
benhandanyan:fix/remove-more-configuration-name-matching-logic
Closed
[iOS] Use configuration type when adding ndebug flag to pods in release#48193benhandanyan wants to merge 2 commits intofacebook:mainfrom benhandanyan:fix/remove-more-configuration-name-matching-logic
benhandanyan wants to merge 2 commits intofacebook:mainfrom
benhandanyan:fix/remove-more-configuration-name-matching-logic
Conversation
benhandanyan
commented
Dec 10, 2024
| installer.aggregate_targets.each do |aggregate_target| | ||
| aggregate_target.xcconfigs.each do |config_name, config_file| | ||
| is_release = config_name.downcase.include?("release") || config_name.downcase.include?("production") | ||
| is_release = aggregate_target.user_build_configurations[config_name] == :release |
Contributor
Author
There was a problem hiding this comment.
benhandanyan
commented
Dec 10, 2024
| installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result| | ||
| target_installation_result.native_target.build_configurations.each do |config| | ||
| is_release = config.name.downcase.include?("release") || config.name.downcase.include?("production") | ||
| is_release = config.type == :release |
Contributor
Author
There was a problem hiding this comment.
cipolleschi
approved these changes
Dec 10, 2024
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
This is great, amazing work. Thank you so much!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 462fae4. |
Collaborator
|
This pull request was successfully merged by @benhandanyan in 462fae4 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While I was working on fixing the iOS debugger logic based on configuration name regex match, I wanted to know if other logic was also based on configuration names. I think I found and fixed the only other configuration name-based logic in the repo in this PR.
Changelog:
[IOS] [CHANGED] - Use configuration type when adding ndebug flag to pods in release
Test Plan:
In a fresh react-native project, I added to the Podfile:
to confirm my logic. It output the following:
I also updated the applicable tests I could find for this logic.