Skip to content

Feat/fontweight number value#34598

Closed
ankit-tailor wants to merge 6 commits intofacebook:mainfrom
ankit-tailor:feat/fontweight-number-value
Closed

Feat/fontweight number value#34598
ankit-tailor wants to merge 6 commits intofacebook:mainfrom
ankit-tailor:feat/fontweight-number-value

Conversation

@ankit-tailor
Copy link
Copy Markdown
Contributor

@ankit-tailor ankit-tailor commented Sep 5, 2022

Summary

This PR adds support for number values for fontWeight as requested in #34425.

Changelog

[General] [Added] - Added support for number values in fontWeight.

Test Plan

<Text style={{ fontWeight: 900, color: 'red' }}>
  Hello World
</Text>

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 5, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 5, 2022
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 5, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4f6929b
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 5, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,638,097 +1,062
android hermes armeabi-v7a 7,050,075 +841
android hermes x86 7,940,060 +1,222
android hermes x86_64 7,912,080 +1,309
android jsc arm64-v8a 9,513,807 +978
android jsc armeabi-v7a 8,289,094 +760
android jsc x86 9,453,350 +1,135
android jsc x86_64 10,044,592 +1,229

Base commit: 4f6929b
Branch: main

necolas
necolas reviewed Sep 6, 2022
View reviewed changes
@necolas necolas mentioned this pull request Sep 6, 2022
Closed
74 tasks
@ankit-tailor ankit-tailor requested a review from necolas September 6, 2022 02:50
@necolas
Copy link
Copy Markdown

necolas commented Sep 6, 2022

Are there any existing unit tests that we can expand to include this change?

@ankit-tailor
Copy link
Copy Markdown
Contributor Author

ankit-tailor commented Sep 6, 2022

No, I couldn't find any existing tests.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2022

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

todorone
todorone reviewed Sep 7, 2022
View reviewed changes
@ankit-tailor @todorone
Remove null check its already in if condition
93acdbf 
Co-authored-by: Fedir Ushakov <pmahotsava@gmail.com>
@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Sep 12, 2022

This pull request was successfully merged by @ankit-tailor in f1c1f81.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 12, 2022
@Freddy03h Freddy03h mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@todorone todorone todorone left review comments

@necolas necolas necolas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ankit-tailor @analysis-bot @necolas @facebook-github-bot @react-native-bot @todorone