add file and blob globals to eslint config #31293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base commit: dbe6fab |
satya164
approved these changes
Apr 2, 2021
Contributor
Author
|
ETA? |
Contributor
|
@shamilovtim don't you mind rebasing as you're far behind in the history. Afterwards we can merge this |
Contributor
Author
|
@cortinico done |
Base commit: dbe6fab |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @shamilovtim in d881c87. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The eslint community config does not have the File and Blob polyfills in
globalswhich have been part of the Javascript implementation for ~3 years. They were added to the Javascript API in #11573 by @satya164.Changelog
[General] [Fixed] - Added File and Blob globals to eslint community config
Test Plan
Evidence these globals exist:
Evidence the PR works: the globals in the PR identical to the others in the eslint community config that they are in