Skip to content

docs: fix broken links in README#30286

Closed
helenaford wants to merge 1 commit intofacebook:masterfrom
helenaford:patch-1
Closed

docs: fix broken links in README#30286
helenaford wants to merge 1 commit intofacebook:masterfrom
helenaford:patch-1

Conversation

@helenaford
Copy link
Copy Markdown
Contributor

@helenaford helenaford commented Oct 30, 2020 •
edited
Loading

Summary

Fix broken links in README by removing .html from any reactnative.dev/docs

Changelog

General Fixed - Fixed broken links in README.md

Test Plan

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

Hi @helenaford!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@helenaford
Copy link
Copy Markdown
Contributor Author

helenaford commented Oct 30, 2020

CLA updated

@pull-bot
Copy link
Copy Markdown

pull-bot commented Oct 30, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against be5ee21

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 30, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 36b0f7d

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

dulmandakh
dulmandakh approved these changes Oct 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @cpojer

facebook-github-bot
facebook-github-bot reviewed Nov 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Simek
Copy link
Copy Markdown
Collaborator

Simek commented Nov 2, 2020

Hi @helenaford, thank you for updating those links! 👍

FYI Also the issue has been fixed globally on the RN website (facebook/react-native-website#2300) by adding the client side redirect so old links (with .html) like https://reactnative.dev/docs/getting-started.html should now work correctly.

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Nov 3, 2020

This pull request was successfully merged by @helenaford in 21349d6.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 3, 2020
@helenaford helenaford deleted the patch-1 branch November 3, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpojer cpojer Awaiting requested review from cpojer

@hramos hramos Awaiting requested review from hramos

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@dulmandakh dulmandakh dulmandakh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@helenaford @facebook-github-bot @pull-bot @analysis-bot @Simek @react-native-bot @dulmandakh