Skip to content

Docker android: addressing AVD launch issue#30279

Closed
fkgozali wants to merge 1 commit intofacebook:masterfrom
fkgozali:export-D24638504
Closed

Docker android: addressing AVD launch issue#30279
fkgozali wants to merge 1 commit intofacebook:masterfrom
fkgozali:export-D24638504

Conversation

@fkgozali
Copy link
Copy Markdown
Contributor

@fkgozali fkgozali commented Oct 30, 2020

Summary:
Take in the fix from #30273 + force starting adb server before launching AVD.

Changelog: [Internal]

Differential Revision: D24638504

@fkgozali @facebook-github-bot
Docker android: addressing AVD launch issue
66bc0ee 
Summary:
Take in the fix from facebook#30273 + force starting adb server before launching AVD.

Changelog: [Internal]

Differential Revision: D24638504

fbshipit-source-id: 236ff8e418b8085636fea27f479ca29edb5b599f
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 30, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

This pull request was exported from Phabricator. Differential Revision: D24638504

@pull-bot
Copy link
Copy Markdown

pull-bot commented Oct 30, 2020

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 66bc0ee

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 30, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 36b0f7d

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Oct 31, 2020

This pull request was successfully merged by @fkgozali in 49d41c9.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpojer cpojer Awaiting requested review from cpojer

@hramos hramos Awaiting requested review from hramos

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fkgozali @facebook-github-bot @pull-bot @analysis-bot @react-native-bot