Upstream RN macOS Hermes integration bits#29748
Closed
alloy wants to merge 3 commits intofacebook:masterfrom
Closed
Upstream RN macOS Hermes integration bits#29748alloy wants to merge 3 commits intofacebook:masterfrom
alloy wants to merge 3 commits intofacebook:masterfrom
Conversation
This removes the need to maintain this in our fork. See: microsoft#473
Otherwise it ends up clashing with Flipper-Folly, which started now that we load more of Folly in RN iOS/macOS due to the increased requirements imposed by Hermes debugging.
Contributor
Author
|
@appden Can you give this a review? 🙏 |
alloy
commented
Aug 24, 2020
Base commit: 1704a72 |
657a36c to
081e7ed
Compare
081e7ed to
f1e3210
Compare
Base commit: 1704a72 |
grabbou
approved these changes
Aug 24, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @alloy in 941bc0e. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft’s RN for macOS fork supports the Hermes engine nowadays microsoft#473. As a longer term work item, we’ve started moving bits that are not invasive for iOS but are a maintenance burden on us—mostly when merging—upstream. Seeing as this one is a recent addition, it seemed like a good candidate to start with.
As to the actual changes, these include:
Folly/Futures,libevent).All of the Hermes bits are automatically enabled, on macOS, when providing the
hermes-engine-darwinnpm package and enabling the Hermes pods.Changelog
[General] [Added] - Upstream RN macOS Hermes integration bits
Test Plan
Building RNTester for iOS and Android still works as before.
To test the actual changes themselves, you’ll have to use the macOS target in RNTester in the macOS fork, or create a new application from
master: