Fix CircleCI by adding dependency on JSI to cxxreact#29087
Closed
ejanzer wants to merge 1 commit intofacebook:masterfrom
Closed
Fix CircleCI by adding dependency on JSI to cxxreact#29087ejanzer wants to merge 1 commit intofacebook:masterfrom
ejanzer wants to merge 1 commit intofacebook:masterfrom
Conversation
Summary: D21908523 added an implicit dependency on `jsi.h` to use functions like `asObject`, etc. For some reason this doesn't break the build with BUCK (??) but it does with cocoapods. Adding the dep to the cxxreact podspec and regenerating offline mirrors to unbreak CircleCI. Also adding the BUCK dep and include statement for good measure. Changelog: [Internal] Differential Revision: D21924592 fbshipit-source-id: 60da149f0bdef5cb07fffae3a5fe930440138c44
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21924592 |
|
Base commit: 6860cb0 |
Base commit: 6860cb0 |
Collaborator
|
This pull request was successfully merged by @ejanzer in a50fa55. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D21908523 added an implicit dependency on
jsi.hto use functions likeasObject, etc. For some reason this doesn't break the build with BUCK (??) but it does with cocoapods. Adding the dep to the cxxreact podspec and regenerating offline mirrors to unbreak CircleCI. Also adding the BUCK dep and include statement for good measure.Changelog: [Internal]
Differential Revision: D21924592