Skip to content

Convert JSEngineInstance into a runtime factory, move runtime ownership to ReactInstance#29009

Closed
ejanzer wants to merge 1 commit intofacebook:masterfrom
ejanzer:export-D21270243
Closed

Convert JSEngineInstance into a runtime factory, move runtime ownership to ReactInstance#29009
ejanzer wants to merge 1 commit intofacebook:masterfrom
ejanzer:export-D21270243

Conversation

@ejanzer
Copy link
Copy Markdown

@ejanzer ejanzer commented May 29, 2020

Summary: OSS changes: Update RCTTurboModuleManager to accept a RuntimeExecutor instead of a jsi::Runtime.

Reviewed By: RSNara

Differential Revision: D21270243

@facebook-github-bot
Convert JSEngineInstance into a runtime factory, move runtime ownersh…
ce3c5de 
…ip to ReactInstance

Summary: OSS changes: Update RCTTurboModuleManager to accept a RuntimeExecutor instead of a `jsi::Runtime`.

Reviewed By: RSNara

Differential Revision: D21270243

fbshipit-source-id: 5770592e3f8e6db237fa8ad37e1109025e95db37
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner RN Team labels May 29, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 29, 2020

This pull request was exported from Phabricator. Differential Revision: D21270243

@pull-bot
Copy link
Copy Markdown

pull-bot commented May 29, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ce3c5de

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 29, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,763,904 0
android hermes armeabi-v7a 6,426,152 0
android hermes x86 7,149,163 0
android hermes x86_64 7,039,676 0
android jsc arm64-v8a 8,932,393 0
android jsc armeabi-v7a 8,587,039 0
android jsc x86 8,760,775 0
android jsc x86_64 9,336,917 0

Base commit: 5d39bfa

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 29, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal 10,746,320 9,936,752

Base commit: 5d39bfa

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Jun 4, 2020

This pull request was successfully merged by @ejanzer in 5c474ac.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ejanzer @facebook-github-bot @pull-bot @analysis-bot @react-native-bot