Reverting Flow related changes from CI 15749 to get builds back in order#12526
Closed
hramos wants to merge 4 commits intofacebook:masterfrom
hramos:master
Closed
Reverting Flow related changes from CI 15749 to get builds back in order#12526hramos wants to merge 4 commits intofacebook:masterfrom hramos:master
hramos wants to merge 4 commits intofacebook:masterfrom
hramos:master
Conversation
Contributor
Author
|
Let's see if these three reverts are sufficient to unbreak CI. |
eslint-bot
reviewed
Feb 22, 2017
| type SectionItem = any; | ||
|
|
||
| type SectionBase<SectionItemT> = { | ||
| type SectionBase = { |
There was a problem hiding this comment.
no-unused-vars: 'SectionBase' is defined but never used.
This reverts commit f2687bf.
Contributor
Author
|
This PR did not initially pass tests: I have now reverted f2687bf which resolved the error above. |
hramos
referenced
this pull request
Feb 22, 2017
Reviewed By: yungsters Differential Revision: D4577395 fbshipit-source-id: 9b9099f5bd5f8fe20b5c24eab7e43f298ba665d9
hramos
referenced
this pull request
Feb 22, 2017
Summary: - Properly inherit flow types from base components, including `defaultProps` - template-ify the `Item` type as it flows from the `data` prop into `ItemComponent` Note that for `SectionList` is is harder to do the `Item` typing because each section in the `sections` array can have a different `Item` type, plus all the optional overrides...not sure how to tackle that. Reviewed By: yungsters Differential Revision: D4557523 fbshipit-source-id: a0c5279fcdaabe6aab5fe11743a99c3715a44032
hramos
referenced
this pull request
Feb 22, 2017
Reviewed By: bvaughn Differential Revision: D4561262 fbshipit-source-id: 990f338c197851252bea4902fa86249d6e1c975b
hramos
referenced
this pull request
Feb 22, 2017
Reviewed By: bvaughn, yungsters Differential Revision: D4563798 fbshipit-source-id: 0591cef7c854b525d77e526af783284d9696cb48
Contributor
|
Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this. |
Contributor
Contributor
Author
|
Not any more, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting 4 commits that introduced new Flow errors during build process. This has resulted in CI not being able to successfully build. The engineer working on this has been tasked.
63d3ea1
5042bae
6283878
f2687bf
Similar to #12450, but does not revert 118e883.
Unlike #12450, this PR should import successfully as I will be using a newer import tool.