[DevTools] Don't connect to pages that are being prerendered#35958
Merged
eps1lon merged 1 commit intofacebook:mainfrom Mar 4, 2026
Conversation
|
Comparing: 4b568a8...e6ee9ca Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
95c1af9 to
e6ee9ca
Compare
hoxyq
approved these changes
Mar 4, 2026
Collaborator
Author
|
Yeah, that file looks also (memory-)leaky at the moment.
I wonder if that's all from not handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35954
Root cause was ping-ponging the proxy connection between the actual page and the prerendered page. Both were battling for the same tab ID.
We'll see if
pageshowfiring while prerendering is actually a bug but even if, it'll take some time to get fixed so we should work around that.How did you test this change?