Fix ReferenceError when requestAnimationFrame isn't defined#13152
Merged
gaearon merged 2 commits intofacebook:masterfrom Jul 5, 2018
Merged
Fix ReferenceError when requestAnimationFrame isn't defined#13152gaearon merged 2 commits intofacebook:masterfrom
gaearon merged 2 commits intofacebook:masterfrom
Conversation
Merged
acdlite
reviewed
Jul 5, 2018
| const localCancelAnimationFrame = | ||
| typeof cancelAnimationFrame === 'function' | ||
| ? cancelAnimationFrame | ||
| : (undefined: any); |
Collaborator
There was a problem hiding this comment.
This module throws if this is undefined, right? Maybe we should use an invariant?
Collaborator
Author
There was a problem hiding this comment.
Didn't want to spend the bytes.
I think it actually used an invariant in the past, and Sebastian wanted to relax that to a warning.
Collaborator
There was a problem hiding this comment.
I guess in sync mode this module is never used so an invariant would be harsh
|
ReactDOM: size: 🔺+0.1%, gzip: 0.0% Details of bundled changes.Comparing: 88d7ed8...9064cf5 react-dom
react-art
react-scheduler
Generated by 🚫 dangerJS |
acdlite
approved these changes
Jul 5, 2018
flarnie
approved these changes
Jul 5, 2018
Contributor
flarnie
left a comment
There was a problem hiding this comment.
I think this makes sense, thanks for fixing. Also thinking we may want to throw if the scheduler starts to try and run and rAF is still undefined. Will consider that for the future.
Contributor
|
Nice! thanks for the fix :) Edit Confirmed that this fixes the regression in the open source project I first noticed it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12980 (comment).
We can't access a global if it's not defined so we should always guard it. I consolidated these reads in one place. I also changed the test to reproduce the problem on master.