Skip to content

fix(semantic_token): differentiate enum member from regular property#2524

Closed
disrupted wants to merge 1 commit intofacebook:mainfrom
disrupted:semantic-tokens-enum-member
Closed

fix(semantic_token): differentiate enum member from regular property#2524
disrupted wants to merge 1 commit intofacebook:mainfrom
disrupted:semantic-tokens-enum-member

Conversation

@disrupted
Copy link
Contributor

@disrupted disrupted commented Feb 24, 2026

No description provided.

@meta-cla
Copy link

meta-cla bot commented Feb 24, 2026

Hi @disrupted!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@disrupted disrupted changed the title fix(semantic_token): differentiate enum member from regular property fgenericix(semantic_token): differentiate enum member from regular property Feb 24, 2026
@disrupted disrupted changed the title fgenericix(semantic_token): differentiate enum member from regular property fix(semantic_token): differentiate enum member from regular property Feb 24, 2026
@meta-cla
Copy link

meta-cla bot commented Feb 24, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Feb 24, 2026
@disrupted disrupted marked this pull request as ready for review February 24, 2026 08:21
@yangdanny97 yangdanny97 self-assigned this Feb 26, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 26, 2026

@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D94529296.

@github-actions
Copy link

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Contributor

@grievejia grievejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync
Copy link

meta-codesync bot commented Feb 27, 2026

@yangdanny97 merged this pull request in 52879e5.

@disrupted disrupted deleted the semantic-tokens-enum-member branch February 27, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants