impl Completions: Auto import submodules. #2207#2311
Closed
asukaminato0721 wants to merge 5 commits intofacebook:mainfrom
Closed
impl Completions: Auto import submodules. #2207#2311asukaminato0721 wants to merge 5 commits intofacebook:mainfrom
asukaminato0721 wants to merge 5 commits intofacebook:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements auto-import suggestions for submodules as part of issue #2207. When a user types a submodule name that's not imported, the IDE will now suggest adding from <parent_module> import <submodule> imports, both in completions and as quick-fix code actions.
Changes:
- Added auto-import completion support for submodules that generates
from parent import submodulestyle imports - Added corresponding code action (quick-fix) suggestions for importing submodules
- Added comprehensive test coverage with new test fixtures and test case
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyrefly/lib/test/lsp/lsp_interaction/test_files/autoimport_submodule/pyrefly.toml | Test configuration file defining search path |
| pyrefly/lib/test/lsp/lsp_interaction/test_files/autoimport_submodule/foo.py | Test file with copyright header (content added dynamically in test) |
| pyrefly/lib/test/lsp/lsp_interaction/test_files/autoimport_submodule/autoimport_submodule_pkg/auto_submodule.py | Test submodule containing a VALUE constant for testing |
| pyrefly/lib/test/lsp/lsp_interaction/test_files/autoimport_submodule/autoimport_submodule_pkg/init.py | Package initialization file for test package |
| pyrefly/lib/test/lsp/lsp_interaction/completion.rs | New test case validating submodule auto-import completions |
| pyrefly/lib/state/lsp.rs | Added code action logic to suggest submodule imports in quick-fix suggestions |
| pyrefly/lib/lsp/wasm/completion.rs | Added completion item logic to suggest submodule imports in auto-completion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
6f7267e to
03c0650
Compare
This comment has been minimized.
This comment has been minimized.
jvansch1
requested changes
Feb 13, 2026
49234b4 to
6b196ab
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Seems like this build is failing for all operating systems. I can take a closer look once that is resolved. |
This comment has been minimized.
This comment has been minimized.
24f57fd to
b2b5d14
Compare
This comment has been minimized.
This comment has been minimized.
b2b5d14 to
8419098
Compare
This comment has been minimized.
This comment has been minimized.
8419098 to
23cce8f
Compare
23cce8f to
50fcdf7
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
kinto0
approved these changes
Mar 4, 2026
Contributor
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
part of #2207
Added auto-import suggestions for submodules so completions insert
from <parent> import <submodule>(and corresponding quickfix entries).Test Plan
Added a new LSP completion test and fixtures.