fix Support bare class names for in-based narrowing #937#2291
Closed
asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
Closed
fix Support bare class names for in-based narrowing #937#2291asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Diff from mypy_primer, showing the effect of this PR on open source code: zulip (https://github.com/zulip/zulip)
+ ERROR zerver/lib/bulk_create.py:199:40-57: Argument `set[Stream | UserProfile]` is not assignable to parameter `objs` with type `Iterable[Stream]` in function `django.db.models.manager.Manager.bulk_update` [bad-argument-type]
+ ERROR zerver/lib/bulk_create.py:199:40-57: Argument `set[Stream | UserProfile]` is not assignable to parameter `objs` with type `Iterable[UserProfile]` in function `django.db.models.manager.Manager.bulk_update` [bad-argument-type]
+ ::error file=zerver/lib/bulk_create.py,line=199,col=40,endLine=199,endColumn=57,title=Pyrefly bad-argument-type::Argument `set[Stream | UserProfile]` is not assignable to parameter `objs` with type `Iterable[Stream]` in function `django.db.models.manager.Manager.bulk_update`
+ ::error file=zerver/lib/bulk_create.py,line=199,col=40,endLine=199,endColumn=57,title=Pyrefly bad-argument-type::Argument `set[Stream | UserProfile]` is not assignable to parameter `objs` with type `Iterable[UserProfile]` in function `django.db.models.manager.Manager.bulk_update`
asynq (https://github.com/quora/asynq)
- ERROR asynq/decorators.py:272:18-27: Expected a callable, got `object` [not-callable]
+ ERROR asynq/decorators.py:279:11-13: Argument `classmethod[Unknown, Ellipsis, Unknown] | staticmethod[Ellipsis, Unknown] | Unknown` is not assignable to parameter with type `(...) -> Unknown` [bad-argument-type]
- ::error file=asynq/decorators.py,line=272,col=18,endLine=272,endColumn=27,title=Pyrefly not-callable::Expected a callable, got `object`
+ ::error file=asynq/decorators.py,line=279,col=11,endLine=279,endColumn=13,title=Pyrefly bad-argument-type::Argument `classmethod[Unknown, Ellipsis, Unknown] | staticmethod[Ellipsis, Unknown] | Unknown` is not assignable to parameter with type `(...) -> Unknown`
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
+ ERROR src/hydra_zen/structured_configs/_implementations.py:1315:20-1323:14: Returned type `list[Unknown] | tuple[Unknown, ...]` is not assignable to declared return type `_T` [bad-return]
+ ::error file=src/hydra_zen/structured_configs/_implementations.py,line=1315,col=20,endLine=1323,endColumn=14,title=Pyrefly bad-return::Returned type `list[Unknown] | tuple[Unknown, ...]` is not assignable to declared return type `_T`
|
|
@grievejia has imported this pull request. If you are a Meta employee, you can view this in D92349969. |
stroxler
requested changes
Feb 9, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
stroxler
approved these changes
Feb 10, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@grievejia merged this pull request in 676728f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #937
in-based narrowing treats bare class objects in list/tuple/set literals as narrowable values (via ClassDef -> type[...] and direct type[...]), and added a small class-object equality case for not in.
Test Plan
Added a regression test covering type[object] narrowed by x in (int, float).