Remove no-longer-necessary LiteralString promotion from solver.rs#2123
Closed
rchen152 wants to merge 1 commit intofacebook:mainfrom
Closed
Remove no-longer-necessary LiteralString promotion from solver.rs#2123rchen152 wants to merge 1 commit intofacebook:mainfrom
rchen152 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: The bug that this promotion addressed is now solved more generally by partial type inference in loops. Differential Revision: D90739317
|
Diff from mypy_primer, showing the effect of this PR on open source code: scikit-learn (https://github.com/scikit-learn/scikit-learn)
+ ERROR sklearn/externals/_arff.py:587:29-47: Argument `str` is not assignable to parameter `object` with type `LiteralString` in function `list.append` [bad-argument-type]
+ ::error file=sklearn/externals/_arff.py,line=587,col=29,endLine=587,endColumn=47,title=Pyrefly bad-argument-type::Argument `str` is not assignable to parameter `object` with type `LiteralString` in function `list.append`
apprise (https://github.com/caronc/apprise)
+ ERROR apprise/plugins/sns.py:671:44-49: Argument `str | Any` is not assignable to parameter `object` with type `LiteralString` in function `list.append` [bad-argument-type]
+ ::error file=apprise/plugins/sns.py,line=671,col=44,endLine=671,endColumn=49,title=Pyrefly bad-argument-type::Argument `str | Any` is not assignable to parameter `object` with type `LiteralString` in function `list.append`
werkzeug (https://github.com/pallets/werkzeug)
+ ERROR src/werkzeug/debug/tbtools.py:418:17-420:50: Argument `str` is not assignable to parameter `object` with type `LiteralString` in function `list.append` [bad-argument-type]
+ ::error file=src/werkzeug/debug/tbtools.py,line=418,col=17,endLine=420,endColumn=50,title=Pyrefly bad-argument-type::Argument `str` is not assignable to parameter `object` with type `LiteralString` in function `list.append`
|
stroxler
approved these changes
Jan 15, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The bug that this promotion addressed is now solved more generally by partial type inference in loops.
Differential Revision: D90739317