fix: 'Go to symbol' now includes methods inside a class#2109
Closed
Karman-singh15 wants to merge 1 commit intofacebook:mainfrom
Closed
fix: 'Go to symbol' now includes methods inside a class#2109Karman-singh15 wants to merge 1 commit intofacebook:mainfrom
Karman-singh15 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Thanks for the PR! Looks good to me, I'll try to get a second review and merge in the next day or two Heads up that the red CI signal is just format, you can run |
stroxler
approved these changes
Jan 14, 2026
grievejia
approved these changes
Jan 14, 2026
Contributor
grievejia
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logic was added to post-process symbols inside a ClassDef.
it allows Stmt::FunctionDef to remain simple (always creating a FUNCTION), and shifts the responsibility of context-awareness (knowing it is a method) to the parent ClassDef.
Any child symbol with SymbolKind::FUNCTION is now converted to SymbolKind::METHOD
Fixes #2051
Test Plan
I updated the existing test
test_document_symbols_normal_file in pyrefly/lib/test/lsp/lsp_interaction/document_symbols.rs
The test uses an existing file normal.py which contains NormalClass and normal_method.
I updated the test assertion to verify that normal_method inside NormalClass has SymbolKind::METHOD.