[easy] Tweak error messages when applying special forms#2057
Closed
fangyi-zhou wants to merge 1 commit intofacebook:mainfrom
Closed
[easy] Tweak error messages when applying special forms#2057fangyi-zhou wants to merge 1 commit intofacebook:mainfrom
fangyi-zhou wants to merge 1 commit intofacebook:mainfrom
Conversation
1. Fix misplaces backticks around `Unpack`. 2. Add a separate `Annotated` error message for incorrect number of arguments. This is because `Annotated` is allowed to be used outside annotations, so the original error message wouldn't be fully accurate.
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D90509961. |
stroxler
approved these changes
Jan 12, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@yangdanny97 merged this pull request in 4b9fd34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unpack.Annotatederror message for incorrect number of arguments. This is becauseAnnotatedis allowed to be used outside annotations, so the original error message wouldn't be fully accurate.Test Plan
python test.py