Skip to content

Hover result for chosen overload does not include tparams #757

@samwgoldman

Description

@samwgoldman

Describe the Bug

6e9983d resolved #739 where we were printing out Var IDs in hover result. There is one remaining issue: we should include tparams if the chosen overload is generic.

Doing this shouldn't be terribly difficult, but it's not trivial because we lose the tparams when we instantiate the generic function during calls. I think the right path is to preserve the tparams in the call target and store alongside the overloads in traces.

Sandbox Link

https://pyrefly.org/sandbox/?code=GYJw9gtgBALgngBwJYDsDmUkQWEMpgBuApiADZgCGAJgFC0DGZlAzi1AMIBcUAdP-QACRUhRq1qxYFGBgwAbQAqAXQAUADx7wExJcoCUUALQA+KIp79etYSXJU6k6bLAaeqGIdOYUMSwNoXVQ59egkpKAAjShA9N1hEXRUvMws+AOiQYP0gA

(Only applicable for extension issues) IDE Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    language-serverIssues specific to our IDE integration rather than type checkingoverloads

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions