Provide maven repo url override for Robolectric to fix OSS CI#630
Closed
colriot wants to merge 2 commits intofacebook:masterfrom
Closed
Provide maven repo url override for Robolectric to fix OSS CI#630colriot wants to merge 2 commits intofacebook:masterfrom
colriot wants to merge 2 commits intofacebook:masterfrom
Conversation
Summary: Abstract away ComponentContext and make all accesses to it explicit by providing a `context` property fbshipit-source-id: 4a7bf6c8d0d099fb6d36c405b435d8bd50f8d946
Summary: On Jan 15, 2020 Maven doesn't support unsecure HTTP communication. More context: https://support.sonatype.com/hc/en-us/articles/360041287334-Central-501-HTTPS-Required As a consequence this fails the build on CI when Robolectric tries to fetch its deps via 'http://repo1.maven.org/maven2'. This diff uses Robolectric's system prop to override default repo url. Differential Revision: D19949460 fbshipit-source-id: c26ffb0fe54b87d508ceddfe56ff259af4070ac3
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19949460 |
Contributor
|
@colriot is the 1st commit correctly added in this CL 😄 ? |
Contributor
Author
|
@pavlospt nope 🙄 |
Contributor
Author
|
Close in favour of #653 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Jan 15, 2020 Maven doesn't support unsecure HTTP communication. More context: https://support.sonatype.com/hc/en-us/articles/360041287334-Central-501-HTTPS-Required
As a consequence this fails the build on CI when Robolectric tries to fetch its deps via 'http://repo1.maven.org/maven2'. This diff uses Robolectric's system prop to override default repo url.
Differential Revision: D19949460