[lexical-playground] Fix: Fixing cursor position after inline equation, fix block equations#8228
Merged
etrepum merged 19 commits intofacebook:mainfrom Mar 16, 2026
Merged
Conversation
Co-authored-by: Bob Ippolito <bob@redivi.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…into equation_issue
Jynx2004
commented
Mar 16, 2026
Contributor
Author
There was a problem hiding this comment.
Why it’s happening:
The selectors that time out are only rendered in rich‑text mode: the toolbar button (Insert specialized editor node) and the equation node (.editor-equation).
Your run is almost certainly in plain‑text E2E mode (E2E_EDITOR_MODE=plain-text), where the toolbar and markdown/equation features are intentionally absent.
Many tests already skip themselves in plain‑text, but EquationNode.spec.mjs didn’t, so it waits forever for elements that will never appear.
Fix applied (safe for rich‑text):
I updated the EquationNode tests to skip when isPlainText is true, matching the rest of the suite.
etrepum
approved these changes
Mar 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the display attribute to the parent div/span of the equation node and setting its value according to the
__inlinevalue taken from the user.lexicalequation.online-video-cutter.com.mp4
Closes #7606
Test plan
Not have added any tests as we can see it in our inspect tab in the particular browser.