[lexical-link]: Refactor: add afterCloneFrom method to LinkNode/AutoLinkNode#8226
Merged
etrepum merged 5 commits intofacebook:mainfrom Mar 16, 2026
Merged
[lexical-link]: Refactor: add afterCloneFrom method to LinkNode/AutoLinkNode#8226etrepum merged 5 commits intofacebook:mainfrom
afterCloneFrom method to LinkNode/AutoLinkNode#8226etrepum merged 5 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
58f6b88 to
5910548
Compare
etrepum
reviewed
Mar 16, 2026
packages/lexical-link/src/__tests__/unit/LexicalLinkNode.test.ts
Outdated
Show resolved
Hide resolved
35ea2ab to
e899c6a
Compare
etrepum
approved these changes
Mar 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes fix some rare bugs that occur when using subclasses extended from LinkNode and relax the typing constraints of the
canBeEmptymethodThis PR adds the classic
afterCloneFrommethod toLinkNodeto avoid copying issues, and adds an additional check to the transformation function to prevent unnecessary operations when no mutations occur.Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
Insert relevant screenshots/recordings/automated-tests