[lexical-markdown] Bug Fix: update backslash escape handling to align with CommonMark#8192
Merged
etrepum merged 11 commits intofacebook:mainfrom Mar 5, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Mar 4, 2026
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
It looks good at first pass but I will have to spend some more time comparing the behavior to commonmark before final approval
etrepum
approved these changes
Mar 5, 2026
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
All of the behavior matches up with CommonMark, but let's make that small cleanup so the code isn't repeated
etrepum
approved these changes
Mar 5, 2026
Collaborator
|
GitHub actions are currently broken so I will have to check back in later |
Contributor
Author
|
I've updated the code style to comply with Prettier. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns with the CommonMark Spec regarding backslash escapes.
The following cases can not supported before update of the related functions:
Related Issue #7824
Close the related issue after addressed the single line recursive list.
Test plan
Before
before.mov
After
after.mov