[lexical-playground] Chore: Remove legacy-events mode#8188
[lexical-playground] Chore: Remove legacy-events mode#8188etrepum merged 5 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Although the https://github.com/facebook/lexical/blob/main/packages/lexical-playground/src/Settings.tsx#L45-L51 |
b7e8c2e to
766ea83
Compare
No |
etrepum
left a comment
There was a problem hiding this comment.
I think you should have a close look at all of the conditional statements that have changed, removing just the subexpressions that referenced the event mode is not always the right thing to do depending on whether it evaluates to true or false with modern events and which logical operator was used.
Co-authored-by: Bob Ippolito <bob@redivi.com>
Description
Legacy-events mode tested lexical's functionality by emulating the unavailability of the
beforeInputevent. Currently, lexical supports the minimum browser versions that already support thebeforeInputevent.This PR completely removes GitHub workflows with legacy events mode and any mentions in tests
Closes #5673
Test plan
Before
Running tests in Github Actions CI was divided into two modes: modern-events and legacy-events. Some test were skipped in legacy-events mode
After
All workflows with legacy events have been removed. Test skips for legacy events mode have been removed